client/app/plugins/0.rpc.ts (1)

4-5: Extract the RPC literals into a shared contract module.

The namespace is duplicated here and in src/devtools.ts, and these hook names now have to stay in sync with the consumer plugins. Please move them into a tiny side-effect-free shared module next to src/rpc-types.ts instead of importing src/devtools.ts into the iframe bundle.

Also applies to: 13-29

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@client/app/plugins/0.rpc.ts` around lines 4 - 5, Move the duplicated RPC
string literals (e.g., RPC_NAMESPACE = 'hints' and the hook names used across
files) into a new tiny, side-effect-free shared module (e.g., next to
src/rpc-types.ts) that exports named constants; then update
client/app/plugins/0.rpc.ts and src/devtools.ts to import those constants
instead of hardcoding the literals or importing src/devtools.ts into the iframe
bundle. Make sure the shared module only exports constants (no runtime side
effects), preserves the exact symbol names used by consumers, and replace all
literal occurrences (RPC_NAMESPACE and the hook name constants referenced in
lines ~13-29) with imports from the new module.

src/runtime/core/server/rpc-bridge.ts (1)

5-7: Race condition concern is theoretical; hooks fire during request handling after devtools initialization.

The code registers hook handlers that will fire during request handling (POST/DELETE routes and response hooks), not during server startup. By the time clients make HTTP requests, the devtools initialization via onDevToolsInitialized() will have already completed. The optional chaining (getRpc()?.broadcast...) gracefully handles the undefined case without runtime errors.

If this is intentional by design (devtools as a debug tool), the current implementation is appropriate. If documentation about this expectation would be helpful, consider adding a comment noting that hooks rely on devtools initialization.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/runtime/core/server/rpc-bridge.ts` around lines 5 - 7, The race-condition
concern is theoretical; document the intended behavior by adding a clear comment
near getRpc() (and/or where getRpc()?.broadcast is called) stating that hooks
(POST/DELETE routes and response hooks) execute during request handling after
onDevToolsInitialized() has completed, and that getRpc() may be undefined until
devtools init but optional chaining intentionally prevents runtime errors;
reference the getRpc function and onDevToolsInitialized to make the expectation
explicit for future readers.

src/devtools.ts (1)

8-8: Avoid duplicated RPC namespace literals across client/server wiring.

RPC_NAMESPACE is hardcoded here and also in client/app/plugins/0.rpc.ts; this can silently break channel alignment during future renames. Centralize it in one shared export (e.g., src/rpc-types.ts) and import from both sides.

♻️ Proposed refactor (server side)

-import type { HintsClientRpc, HintsServerRpc } from './rpc-types'
+import { RPC_NAMESPACE, type HintsClientRpc, type HintsServerRpc } from './rpc-types'

-export const RPC_NAMESPACE = 'hints'

Also apply the same shared import in client/app/plugins/0.rpc.ts to remove the second literal.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/devtools.ts` at line 8, RPC_NAMESPACE is duplicated as a hardcoded
literal; create a single shared export (e.g., export const RPC_NAMESPACE =
'hints' in a new module named rpc-types) and update both places that currently
hardcode the string to import RPC_NAMESPACE from that module. Replace the
literal in the existing export of RPC_NAMESPACE with an import from the new
shared module and update the client plugin file that contains the second literal
(the 0.rpc plugin) to import the same RPC_NAMESPACE instead of redefining it,
ensuring both sides use the single shared symbol.